Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSimplify TopLevel and Static export handling #4170
Conversation
gzm0
force-pushed the
gzm0:cleanup-exports
branch
2 times, most recently
from
9647182
to
ffd3e76
|
Looks good. I only have minor comments. |
compiler/src/main/scala/org/scalajs/nscplugin/JSGlobalAddons.scala
Outdated
Show resolved
Hide resolved
|
The AppVeyor build seems to have suffered an infrastructure failure. Is there a way I can restart it? |
If you login into AppVeryor with your GitHub account, you should be able to trigger re-builds. I've done it for this build now. |
I can't find the button. Are you sure I have the appropriate permissions? If I click on "Projects" in the nav bar, the scala-js repository does not show up. |
|
You're an Owner of the scala-js organization, so you should have all privileges. Perhaps you need to explicitly sync your AppVeyor profile with your GitHub permissions? |
How do I do that? I have tried: Installing the AppVeyor GitHub app for myself (gzm0) and the scala-js organization. |
|
Apparently the AppVeyor builds are configured with my personal account, instead of through the scala-js org. The problem is that I have no idea how to fix it, nor even to recreate the project under the scala-js org from the AppVeyor point of view :s |
gzm0 commentedAug 30, 2020
No description provided.