Tweak .codedoc.yml to make it more useful #71
5 participants
| - default: | ||
| - threshold: 0.01 | ||
| + only_pulls: true | ||
| + paths: |
I'm guessing this means it only ends up being run for those directories, right? If so, that's good that it avoids being run on, e.g., Doc/* changes, but shouldn't it also run on directories like Objects/?
I'm guessing this means it only ends up being run for those directories, right?
Correct.
[...] but shouldn't it also run on directories like Objects/?
Good point. I'm reading docs again so I hopefully will have an answer :)
According to https://docs.codecov.io/docs/commit-status#section-patch-status, we don't need to add specific directories. It should only look for the changes in PR.
We can also add directories to ignore: https://docs.codecov.io/docs/ignoring-paths
This seems ok from what I understand of the docs (particularly the coverage/status/{changes|project} part), but I'd prefer to leave it to another set of eyes to approve.
| + - "Mac/**/*" | ||
| + - "PC/**/*" | ||
| + - "PCbuild/**/*" | ||
| + - "Tools/**/*" |
|
LGTM. If you can pass it through Codecov's verification tool at https://docs.codecov.io/docs/codecov-yaml#section-validate-your-repository-yaml that would be great. |
|
Thanks for the review!
$ curl -XPOST --data-binary @.codecov.yml https://codecov.io/validate
Valid!
# Pretty-printed version of the configuration below |
|
Then I say merge it and let python-dev (or -committers; wherever @haypo emailed) know about the requisite change. |
No description provided.