Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Django.gitignore #3493

Open
wants to merge 2 commits into
base: master
from
Open

Create Django.gitignore #3493

wants to merge 2 commits into from

Conversation

@sarveshggn
Copy link

@sarveshggn sarveshggn commented Aug 5, 2020

Added a gitignore file for Django.
I added this file because there was no gitignore file for Django.

Added a gitignore file for django
Copy link

@JubayerJoy JubayerJoy left a comment

Great Work! 👍
I have a suggestion, please consider adding comments for explaining which files are affected by gitigonre.
for reference please view this PR.
Thanks!

Added comments and a short description of why one needs those.
@sarveshggn
Copy link
Author

@sarveshggn sarveshggn commented Aug 5, 2020

Added comments and appropriate explanation for the files.

Copy link

@JubayerJoy JubayerJoy left a comment

Seems good to go 👍

@JubayerJoy
Copy link

@JubayerJoy JubayerJoy commented Aug 6, 2020

There was already a PR for Django which was merged, but can't find it.
I wonder what happened 😕

@sarveshggn
Copy link
Author

@sarveshggn sarveshggn commented Aug 7, 2020

Yes but I think it was removed, as I didn't find it there.

@0417yjy
Copy link

@0417yjy 0417yjy commented Oct 9, 2020

I was looking for the Django gitignore. I hope this request would be approved.

@sarveshggn
Copy link
Author

@sarveshggn sarveshggn commented Oct 10, 2020

Let's hope for the best!

@53jk1
53jk1 approved these changes Oct 23, 2020
@sarveshggn
Copy link
Author

@sarveshggn sarveshggn commented Dec 22, 2020

@shiftkey Can you review this PR once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants