TheAlgorithms / Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createminimum number of refills.py #2388

Open

Saptarshi-prog wants to merge 1 commit into TheAlgorithms:master from Saptarshi-prog:patch-3

Saptarshi-prog commented Sep 2, 2020

Added a new algorithm

Describe your change:

[x ] Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

[x ] I have read CONTRIBUTING.md.
[x ] This pull request is all my own work -- I have not plagiarized.
[ x] I know that pull requests will not be merged if they fail the automated tests.
[x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
[ x] All new Python files are placed inside an existing directory.
[x ] All filenames are in all lowercase characters with no spaces or dashes.
[ x] All functions and variable names follow Python naming conventions.
[ x] All function parameters and return values are annotated with Python type hints.
[x ] All functions have doctests that pass the automated testing.
[x ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
[x ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.


        Create minimum_number_of_refills.py

d8ab904

Added a new algorithm

TravisBuddy commented Sep 2, 2020

Hey @Saptarshi-prog,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy Request Identifier: 607ebe30-ed35-11ea-b6ba-27fe84eba218

Member

cclauss commented Sep 2, 2020

GitHub task list work like this https://github.blog/2014-04-28-task-lists-in-all-markdown-documents/

Please do not check the task that says that you have read CONTRIBUTING.md if you have not done so.

Contributor

spamegg1 commented Sep 9, 2020

@Saptarshi-prog Build log says

6 E225 missing whitespace around operator
4 E226 missing whitespace around arithmetic operator
5 E231 missing whitespace after ','
2 E262 inline comment should start with '# '
1 E302 expected 2 blank lines, found 1
1 E305 expected 2 blank lines after class or function definition, found 1

Can be easily fixed by running black on your file. CONTRIBUTING.md explains it. Please read it.

cclauss requested changes

greedy_method/minimum_number_of_refills.py

  
        arr.insert(0,int(0))

        arr.append(B)

        def MinRefills(x,n,L):

cclauss Sep 9, 2020

Member

Single letter variable names are old school as discussed in CONTRIBUTING.md

No python type hints
No doctests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.