Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import to fix warnings #23

Merged
merged 1 commit into from Apr 27, 2020
Merged

Update import to fix warnings #23

merged 1 commit into from Apr 27, 2020

Conversation

@tbries
Copy link

tbries commented Apr 24, 2020

Got sick of the same warning over and over again adding noise to the local dev command line.

The warning is:

/Users/tbries/source/airflow-sources/.venv/src/apache-airflow/airflow/www/app.py:193: DeprecationWarning: 'werkzeug.wsgi.DispatcherMiddleware' has moved to 'werkzeug.middleware.dispatcher.DispatcherMiddleware'. This import is deprecated as of version 0.15 and will be removed in version 1.0.

@preston-m-price I see you merged a PR in this repo a while back. Is there anything I need to do for this change to propagate to the local dev environment once this change is merged?

cc: @github/data-engineering

@msempere
Copy link

msempere commented Apr 25, 2020

@tbries to start using this change locally after the merge, the only thing you need to do is to re-bootstrap your environment. Bootstrap script is the one in charge of installing the project dependencies: https://github.com/github/airflow-sources/blob/master/script/bootstrap#L66
If you would like to test it before the merge, to see how it would look like, then on here https://github.com/github/airflow-sources/blob/master/config/requirements/development.txt#L2 you could change it to point to your branch, and re-bootstrap.

@tbries
Copy link
Author

tbries commented Apr 27, 2020

Confirmed changes work as expected after bootstrapping my environment with my branch.

@tbries tbries merged commit 7284c09 into gh-1.10.3 Apr 27, 2020
@msempere msempere deleted the tbries-import-fix branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.