Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd python packaging. #236
Open
Conversation
Modified from pybind11
|
I think this is a great idea, which I do in my shadow package as well : https://github.com/tdegeus/pyxtensor . What do others think ? @JohanMabille @SylvainCorlay @wolfv |
|
To sum up #96, the idea would be to keep this repo pure C++ and add a new repo (xtensor.py) that would contain the pure python stuff. The python package would vendor all dependencies (xtensor, xsimd and xtl). This would be consistent with what we do for the R and Julia bindings. |
|
Makes sense @JohanMabille . Will be much easier to maintain and ship. So all for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
StefanUlbrich commentedApr 4, 2020
Installs headers via pip. Suitable for rapidly writing packages. Modified from the pybind11. Xtensor itself should be packaged and dded as a dependency too.