Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate CMakeLists to correctly find pybind11 alias targets #242
Conversation
Add an additional TARGET check in the root cmake file to correctly find the pybind11 alias targets.
|
I wonder if this is not more an issue of pybind11? Why is the target not defined? |
nickrobison-usds
added a commit
to nickrobison-usds/mobility-cpp
that referenced
this pull request
Sep 15, 2020
Add the required submodules for python integration. We're using our own branch of xtensor-python, while we wait for the [PR](xtensor-stack/xtensor-python#242) to be merged.
nickrobison-usds
added a commit
to nickrobison-usds/mobility-cpp
that referenced
this pull request
Sep 15, 2020
Add the required submodules for python integration. We're using our own branch of xtensor-python, while we wait for the [PR](xtensor-stack/xtensor-python#242) to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nickrobison-usds commentedSep 9, 2020
When building xtensor-python and pybind11 as cmake submodule projects, the pybind aliased targets are not discovered correctly.
This PR adds an additional check to also look for the
pybind11:headersaliased target and set the values accordingly.