Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(trigger): replace yarn publish with npm publish #919
Conversation
|
you could set the registry in the yarnrc too, although I'm not sure how that works when shipjs is in node_modules |
|
@Haroenv didn't see you comment here. You're right. That env var didn't work and now I'm trying again with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR replaces
yarn publishwithnpm publisheven if user is usingyarn.yarn publishusesyarn packunder the hood, and there is a critical bug inyarn pack.Replacing
yarn publishwithnpm publishrequires an extra job, which is to setregistryto the one of npm. Even though Ship.js callsnpm publish, if it's triggered byyarn shipjs trigger, then yarn overrides the registry. It's coming from~/.yarnrc. To revert this back, we need to prependnpm_config_registry=https://registry.npmjs.org/to set the registry correctly.