Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the odd `.env.tpl` file #120

Closed
mcuadros opened this issue Feb 15, 2018 · 4 comments
Closed

Stop using the odd `.env.tpl` file #120

mcuadros opened this issue Feb 15, 2018 · 4 comments
Assignees
Labels

Comments

@mcuadros
Copy link

@mcuadros mcuadros commented Feb 15, 2018

As explained here:
#36 (comment)

The usage of env file, populated with empty env vars is odd, and not very Devops friendly since handly configuration files is a something to be avoided, even if it contains env vars.

The env vars should be explicitly defined in all the examples, and be omitted if contains the default value or are empty, in the same that this should be explicitly defined in the `.travis.yml.

@smacker
Copy link
Contributor

@smacker smacker commented Feb 15, 2018

I believe we don't use .env file anywhere besides local dev. Travis, k8s, drone all have defined variables in yml files.

@mcuadros
Copy link
Author

@mcuadros mcuadros commented Feb 15, 2018

Its explained as the default method to keep the variable in the README.md

@smacker
Copy link
Contributor

@smacker smacker commented Feb 15, 2018

that must be fixed!

@dpordomingo
Copy link
Contributor

@dpordomingo dpordomingo commented Feb 15, 2018

(@bzz as you explained to me I moved this issue to backlog after adding to the project)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.