Skip to content

update copyright for changed files before release #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

ddsharpe
Copy link
Member

@ddsharpe ddsharpe commented Feb 5, 2020

Reviewing files that were updated for the upcoming release but didn't get the copyright updated.

@@ -23,4 +23,4 @@ imagetool @/path/to/build_args
```

### Copyright
Copyright (c) 2019 Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

@rosemarymarano rosemarymarano Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the new copyright rule was: There is no need to update existing notices just to make this modification, but you should not use “All rights reserved” in new notices that you create or existing notices that you are updating for other reasons."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I will remove the "all rights reserved". The documentation was updated in previous PRs but the copyright wasn't updated. I reviewed the files prior to cutting the next release and thought they needed to be updated.

Copy link
Member

@markxnelson markxnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ddsharpe ddsharpe merged commit 0013512 into master Feb 5, 2020
@ddsharpe ddsharpe deleted the copyright-updates branch February 5, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants