Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to babel 7 #8948

Merged
merged 1 commit into from Oct 23, 2018
Merged

Upgraded to babel 7 #8948

merged 1 commit into from Oct 23, 2018

Conversation

@vikr01
Copy link
Contributor

vikr01 commented Oct 15, 2018

What kind of change does this PR introduce? (check at least one)

  • Feature
  • Build-related changes

Does this PR introduce a breaking change? (check one)

  • No

The PR fulfills these requirements:

Other information:

  • Upgrades all babel dependencies to work with babel v7. babel-preset-flow-vue is not compatible, so I've recreated it in the .babelrc.js directly.

  • Also changed the jasmine.json files to jasmine.js so that require.resolve can be used instead of assuming where node_modules are. With things like plug'n'play coming to yarn, this is a necessary change.

@vikr01 vikr01 force-pushed the vikr01:feature/babel-7 branch to 371f687 Oct 20, 2018
@Shyam-Chen
Copy link
Contributor

Shyam-Chen commented Oct 23, 2018

Vue 3 will use TypeScript.

@angelina999990
Copy link

angelina999990 commented Oct 23, 2018

@Shyam-Chen Why will Vue3.X decide to use TypeScript ? What is the pros and cons?

@yyx990803 yyx990803 merged commit 12e8efc into vuejs:dev Oct 23, 2018
5 checks passed
5 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
@yyx990803
Copy link
Member

yyx990803 commented Oct 23, 2018

Thanks!

michaelromose added a commit to michaelromose/vue that referenced this pull request Nov 30, 2018
@vikr01 vikr01 deleted the vikr01:feature/babel-7 branch Jan 2, 2019
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
zhiguangphoenix pushed a commit to zhiguangphoenix/vue that referenced this pull request May 2, 2020
aJean added a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.