TheAlgorithms / Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Digit Count program #234

Open

Utsav1999 wants to merge 5 commits into TheAlgorithms:master from Utsav1999:utsav-js-math

Utsav1999 commented Jul 25, 2020

Welcome to JavaScript community

Describe your change:

I added a program that will ask a user to give a number as an input. Then it will count the number of digits present in the number and will print it to the console.

Utsav1999 added 2 commits


        Added Digit Count program

40b4e8f


        Updated

b73ebbf

itsvinayak added the failing npm standards label

Author

Utsav1999 commented Jul 28, 2020

how to add npm standards?

Contributor

nandanvasudevan commented Aug 2, 2020

how to add npm standards?

Just run npm install, it will install all the dependecies.
Then run standard CountDigit.js
Fix the errors and push


        Updated

d6f7569

Sheraff commented Aug 6, 2020

This doesn't work for 0 I think. It will return -Infinity.

Utsav1999 added 2 commits


        Checked with 0 and negative numbers

093236d


        fix error - 1

a03a19e

Author

Utsav1999 commented Aug 7, 2020

@Sheraff thanks for notifying me. I have updated my program and it's working fine now.

itsvinayak reviewed

Maths/CountDigit.js Outdated

  
        }

        console.log('The number of digits in the number: ' + CountDigit(parseInt(prompt('Enter number: '))));

itsvinayak Aug 7, 2020 Member

@Utsav1999, thank you for your contribution

this is from the library function
const prompt = require('prompt-sync')();
this line is required
we are using nodejs to run and test code.
prompt is a lib function to take input, window.prompt will not work in node
to install
npm install prompt-sync

itsvinayak self-requested a review

itsvinayak dismissed their stale review

some thing went wrong

Author

Utsav1999 commented Aug 11, 2020

any update @itsvinayak ?

itsvinayak requested changes

Member

itsvinayak left a comment •

edited

@Utsav1999, thank you for your contribution

this is from the library function
const prompt = require('prompt-sync')();
this line is required
we are using nodejs to run and test code.
prompt is a lib function to take input, window.prompt will not work in node
to install
npm install prompt-sync

resource
plz make this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.