Codecov Report

Merging #225 into master will increase coverage by 3.87%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   93.69%   97.57%   +3.87%     
==========================================
  Files          37       37              
  Lines         984     1113     +129     
  Branches       59        0      -59     
==========================================
+ Hits          922     1086     +164     
+ Misses         29       27       -2     
+ Partials       33        0      -33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b00c4c...613c70b. Read the comment docs.

And for this one as well, I'll review them at the same time (this week some time).

@qchateau I am using your fork, however muiltthread servers still crash for me. As soon as the client closes the connection regardless if the client is doing async or not. Do you have any ideas?

I don't have much time atm but send me a sample code to reproduce your crash and I'll take a look

@qchateau

I don't have much time atm but send me a sample code to reproduce your crash and I'll take a look

Ok, I have figured out what the cause is, and created a MWE.

in the calculator example if you replace the subtraction function with:
struct subtractor { double operator()(double a, double b) { int ax = 0; std::this_thread::sleep_for(std::chrono::milliseconds(1000)); std::cout << "Sleep complete"; return a - b; } };

Then you change the server to run async(4) (for example, any thing more than 1 will cause the crash). Then close the client before the function returns.

The server will crash immediately. I consider myself a beginner, but I really love this RPC implementation, it is the simplest I have seen, so I will see if I can figure something out!

@qchateau I know you said you dont have much time so i made a gist with the proper code. The example client doesn't need to be modified.

server: https://gist.github.com/dossjh/582b050802a9634df756b0e9c0969baa

Thanks for your help.

I don't know how you get there. Testing it on my fork and it runs without troubles. I replaced calculator_server.cc with your codeand had to change the server port to rpc::constants::DEFAULT_PORT.

$ git show
commit c4fb37acbe67ec99e47e5187acd2a7450bde0cec (HEAD -> master, origin/master, origin/HEAD)
Merge: 9fabdbf 38315c0
Author: Quentin Chateau <quentin.chateau@gmail.com>
Date:   Thu Jun 20 23:54:30 2019 +0200

    Merge pull request #15 from tan-yue/master
    
    patch for gcc version < 5 std::put_time unavailable

I'm using Ubuntu 18.10, GCC 8.3.0, and compiled in Release mode.