Skip to content

Remove dead code from tracemalloc (GH-21029) #21029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 21, 2020

tracemalloc_get_frame() checked filename == NULL two times in a row.

Signed-off-by: Christian Heimes christian@python.org

Automerge-Triggered-By: @tiran

Automerge-Triggered-By: @tiran

tracemalloc_get_frame() checked filename == NULL two times in a row.

Signed-off-by: Christian Heimes <christian@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tiran tiran changed the title Remove dead code from tracemalloc Remove dead code from tracemalloc (GH-21029) Jun 27, 2020
@tiran tiran merged commit 9cfcdb7 into python:master Jun 27, 2020
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@tiran tiran deleted the tracemalloc_deadcode branch June 27, 2020 12:13
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2020
tracemalloc_get_frame() checked filename == NULL two times in a row.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 9cfcdb7)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 27, 2020
@bedevere-bot
Copy link

GH-21178 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jun 27, 2020
tracemalloc_get_frame() checked filename == NULL two times in a row.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 9cfcdb7)

Co-authored-by: Christian Heimes <christian@python.org>
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
tracemalloc_get_frame() checked filename == NULL two times in a row.

Signed-off-by: Christian Heimes <christian@python.org>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
tracemalloc_get_frame() checked filename == NULL two times in a row.

Signed-off-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants