Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41812: Fill missing the parts of url path #22319

Closed
wants to merge 1 commit into from

Conversation

cocoatomo
Copy link
Contributor

@cocoatomo cocoatomo commented Sep 19, 2020

@cocoatomo
Copy link
Contributor Author

Could someone attach a "skip news" label?

@kanoekakihito
Copy link

Hi, I've come across the same problem that cocoatomo reported and checked some pages of all translated docs.

  1. The current master code works fine when I've clicked the link at the top of bugs.html of the English doc.
    got 404 at the other language docs.

  2. I've checked the HTML at https://docs.python.org/ja/3/bugs.html and the broken link is <a href="../index.html">Documentation</a>. The URL format of the bugs.html is like https://docs.python.org/{language}/3/bugs.html while the English doc URL is https://docs.python.org/3/bugs.html. This is why I got 404 except English doc.
    As I haven't checked all pages yet so this is just a guess for now: when you click the URL at the top of the page in doc(except English), it fails in case that the URL format doesn't match https://docs.python.org/3/{some_directory}/{some_page}.html format. If this is true you'll get 404 when you clicked the link from about.html, bugs.html, search.html, py-modindex.html, genindex.html, contents.html, glossary.html, license.html and copyright.html, too.

  3. I also clicked the link (of the breadcrumb list) at the bottom of the bugs.html, I don't get the 404 at the all language docs.

Hope it helps.

@JulienPalard
Copy link
Member

This is not needed, as this section is only used for local builds. It's replaced by docsbuild scripts to add the switchers.

The referenced bug is fixed in: python/docsbuild-scripts@c23b401.

Thanks for the PR @cocoatomo, and thanks @kanoekakihito for the study of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants