Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix host datatype in addr of socket.create_server example. #17706
Conversation
This comment has been minimized.
This comment has been minimized.
|
@asvetlov It will be helpful to have your review of this doc change. Thanks. |
|
LGTM! |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 11, 2020
|
Thanks @tirkarthi for the PR |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 11, 2020
|
GH-17948 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 11, 2020
miss-islington
added a commit
that referenced
this pull request
Jan 11, 2020
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
Host as None in address raises TypeError since it should be string, bytes or bytearray.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
Host as None in address raises TypeError since it should be string, bytes or bytearray.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
Host as None in address raises TypeError since it should be string, bytes or bytearray.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tirkarthi commentedDec 26, 2019
The example raises a
TypeErrorthat host part of addr should be str, bytes or bytearray expected.