Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38527: fix configure script for Solaris #16845

Merged
merged 3 commits into from Apr 1, 2020
Merged

bpo-38527: fix configure script for Solaris #16845

merged 3 commits into from Apr 1, 2020

Conversation

@wiggin15
Copy link
Contributor

@wiggin15 wiggin15 commented Oct 19, 2019 •
edited by miss-islington

On Solaris, the regular "grep" command may be an old version that fails to search a binary file. We need to use the correct command (ggrep, in our case), which is found by the configure script earlier.

https://bugs.python.org/issue38527

Automerge-Triggered-By: @pablogsal
Arnon Yaari
bpo-38527: fix configure script for Solaris
Loading status checks…
47d66aa
@isidentical
isidentical approved these changes Feb 29, 2020
View changes
@isidentical isidentical requested a review from jcea Feb 29, 2020
@isidentical
Copy link
Member

@isidentical isidentical commented Feb 29, 2020

Tested on SunOS gcc-solaris11 5.11 11.3 sun4u sparc SUNW,SPARC-Enterprise, works well.
@inorton
Copy link
Contributor

@inorton inorton commented Mar 23, 2020

Hi, I just hit this on Solaris 11.3. the fix looks ok to me. @wiggin15 I think you only need to add the news item
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6b4d4ba
@isidentical isidentical requested a review from pablogsal Apr 1, 2020
@isidentical
Copy link
Member

@isidentical isidentical commented Apr 1, 2020

This is a really short change but that is needed in every time I had to compile CPython on solaris so it would be super cool to get this merged.
@pablogsal
pablogsal reviewed Apr 1, 2020
View changes
Misc/NEWS.d/next/Build/2020-03-28-10-43-09.bpo-38527.fqCRgD.rst Outdated Show resolved Hide resolved
@pablogsal
Update Misc/NEWS.d/next/Build/2020-03-28-10-43-09.bpo-38527.fqCRgD.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b4feaf5
@pablogsal
pablogsal approved these changes Apr 1, 2020
View changes
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 1, 2020

@wiggin15: Status check is done, and it's a success ✅ .
@miss-islington miss-islington merged commit 5dd8360 into python:master Apr 1, 2020
8 of 9 checks passed
8 of 9 checks passed
Docs Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200401.21 succeeded
Details
bedevere/issue-number Issue number 38527 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 1, 2020

Thanks @wiggin15 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Apr 1, 2020
@wiggin15 @miss-islington
bpo-38527: fix configure script for Solaris (pythonGH-16845)
7cd50fe 
On Solaris, the regular "grep" command may be an old version that fails to search a binary file. We need to use the correct command (ggrep, in our case), which is found by the configure script earlier.

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 5dd8360)

Co-authored-by: Arnon Yaari <wiggin15@yahoo.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 1, 2020

GH-19279 is a backport of this pull request to the 3.8 branch.
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 1, 2020

Sorry, @wiggin15, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5dd836030e0e399b21ab0865ae0d93934bdb3930 3.7
@miss-islington miss-islington self-assigned this Apr 1, 2020
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 1, 2020

Thanks @wiggin15 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 1, 2020

Sorry @wiggin15, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5dd836030e0e399b21ab0865ae0d93934bdb3930 3.7
@pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 1, 2020

@wiggin15 @isidentical Could you do the backport to 3.7 using cherry_picker?
miss-islington added a commit that referenced this pull request Apr 1, 2020
@miss-islington @wiggin15
bpo-38527: fix configure script for Solaris (GH-16845)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc03640 
On Solaris, the regular "grep" command may be an old version that fails to search a binary file. We need to use the correct command (ggrep, in our case), which is found by the configure script earlier.

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 5dd8360)

Co-authored-by: Arnon Yaari <wiggin15@yahoo.com>
@wiggin15
Copy link
Contributor Author

@wiggin15 wiggin15 commented Apr 1, 2020

@pablogsal Thanks for merging this! The file was added in 3.8. No need to backport.
@pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 1, 2020

Great, thanks for the PR!
vegerot added a commit to vegerot/cpython that referenced this pull request Jun 10, 2020
@wiggin15 @vegerot
bpo-38527: fix configure script for Solaris (pythonGH-16845)
7250e28 
On Solaris, the regular "grep" command may be an old version that fails to search a binary file. We need to use the correct command (ggrep, in our case), which is found by the configure script earlier.

Automerge-Triggered-By: @pablogsal
vegerot added a commit to vegerot/cpython that referenced this pull request Jun 10, 2020
@wiggin15 @vegerot
bpo-38527: fix configure script for Solaris (pythonGH-16845)
d52ec72 
On Solaris, the regular "grep" command may be an old version that fails to search a binary file. We need to use the correct command (ggrep, in our case), which is found by the configure script earlier.

Automerge-Triggered-By: @pablogsal
gmelikov added a commit to gmelikov/cpython that referenced this pull request Aug 22, 2020
@wiggin15 @gmelikov
bpo-38527: fix configure script for Solaris (pythonGH-16845)
09b6e88 
On Solaris, the regular "grep" command may be an old version that fails to search a binary file. We need to use the correct command (ggrep, in our case), which is found by the configure script earlier.

Automerge-Triggered-By: @pablogsal
chrisburr added a commit to chrisburr/cpython that referenced this pull request Dec 9, 2020
@wiggin15 @chrisburr
bpo-38527: fix configure script for Solaris (pythonGH-16845)
8350e33 
On Solaris, the regular "grep" command may be an old version that fails to search a binary file. We need to use the correct command (ggrep, in our case), which is found by the configure script earlier.

Automerge-Triggered-By: @pablogsal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@isidentical isidentical

@jcea jcea

Assignees

@miss-islington miss-islington

Labels
🤖 automerge CLA signed needs backport to 3.7
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@wiggin15 @isidentical @inorton @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni
You can’t perform that action at this time.