Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExternalize animejs and hammerjs for lower bundle size #170
Conversation
|
will this work even if vue-toasted is included using a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
therealpecus commentedJul 24, 2020
This PR moves animejs and hammerjs (two popular libraries) from dev dependencies to peer dependencies by declaring them as externals in webpack config.
Updates README.md with installation instructions for all environments.
Reason for the PR
It allows VueJS projects to rely on both libraries as single dependencies, without duplicating bundle size.
Without this PR, a project that needed either animejs or hammerjs would ship the libraries twice: once for vue-toasted (in the built minified plugin), and once as a project dependency, needlessly wasting download and parse and compile time on the client.