Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41840: Report module-level globals as both local and global in the symtable module #22391

Merged
merged 1 commit into from Oct 3, 2020
Merged

bpo-41840: Report module-level globals as both local and global in the symtable module #22391

merged 1 commit into from Oct 3, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 23, 2020 •
edited by bedevere-bot

@pablogsal pablogsal changed the title Report module-level globals as both local and global in the symtable module bpo-41840: Report module-level globals as both local and global in the symtable module Sep 23, 2020
@pablogsal pablogsal force-pushed the bpo-41840 branch 2 times, most recently from dfca0a8 to dc8fb13 Compare Sep 23, 2020
ZackerySpytz
ZackerySpytz reviewed Oct 2, 2020
View changes
Lib/symtable.py Outdated Show resolved Hide resolved
Lib/symtable.py Outdated Show resolved Hide resolved
@pablogsal pablogsal merged commit fb0a465 into python:master Oct 3, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 3, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the bpo-41840 branch Oct 3, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Oct 3, 2020

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fb0a4651f1be4ad936f8277478f73f262d8eeb72 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Oct 3, 2020

Sorry @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker fb0a4651f1be4ad936f8277478f73f262d8eeb72 3.8

pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 3, 2020
@pablogsal
[3.9] bpo-41840: Report module-level globals as both local and global…
ae1a2af 
… in the symtable module (pythonGH-22391).

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 3, 2020

GH-22528 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 3, 2020
@pablogsal
[3.8] bpo-41840: Report module-level globals as both local and global…
4a7f1f8 
… in the symtable module (pythonGH-22391).

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Oct 3, 2020
@pablogsal
[3.9] bpo-41840: Report module-level globals as both local and global…
7b7aa94 
… in the symtable module (GH-22391). (GH-22528)

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Oct 3, 2020
@pablogsal
[3.8] bpo-41840: Report module-level globals as both local and global…
fd22823 
… in the symtable module (GH-22391). (GH-22529)

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@pablogsal
bpo-41840: Report module-level globals as both local and global in th…
1119448 
…e symtable module (pythonGH-22391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz

Assignees

@pablogsal pablogsal

Labels
needs backport to 3.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pablogsal @miss-islington @bedevere-bot @ZackerySpytz @the-knights-who-say-ni