Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41861: Convert _sqlite3 RowType and StatementType to heap types #22444

Merged
merged 3 commits into from Oct 1, 2020

Conversation

Copy link
Contributor

@erlend-aasland erlend-aasland commented Sep 28, 2020

Part 3 of bpo-41861, @vstinner

Tested for ref. leaks with ./python.exe -m test -F -r -j1 -R 3:10 test_sqlite

https://bugs.python.org/issue41861

Copy link
Member

@vstinner vstinner left a comment

LGTM if you remove Py_TPFLAGS_HEAPTYPE.

Modules/_sqlite/statement.c Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Author

@erlend-aasland erlend-aasland commented Sep 28, 2020

LGTM if you remove Py_TPFLAGS_HEAPTYPE.

See 6d22771

Copy link
Member

@vstinner vstinner left a comment

LGTM.

@erlend-aasland
Copy link
Author

@erlend-aasland erlend-aasland commented Sep 29, 2020

@vstinner Any idea why the macOS tests are failing? I'm unable to see the details (perhaps due to a recent change in the CI?). I'm tempted to just re-run the checks.

@vstinner
Copy link

@vstinner vstinner commented Oct 1, 2020

@vstinner Any idea why the macOS tests are failing? I'm unable to see the details (perhaps due to a recent change in the CI?). I'm tempted to just re-run the checks.

I don't see any logs. It looks like a bug on the GitHub Action. I don't know how to debug such issue.

These checks are not mandatory, you can safely ignore it.

@vstinner vstinner merged commit 9031bd4 into python:master Oct 1, 2020
8 of 11 checks passed
@vstinner
Copy link

@vstinner vstinner commented Oct 1, 2020

Merged, thanks. Next? :-)

@erlend-aasland
Copy link
Author

@erlend-aasland erlend-aasland commented Oct 1, 2020

Merged, thanks. Next? :-)

Thanks, coming right up! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants