cube-js / cube.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(cubejs-cli): Ability to select JDBC driver #1149

Open

ovr wants to merge 2 commits into master from cubejs-cli-fix-jdbc-create

Member

ovr commented Sep 28, 2020

Check List

Tests has been run in packages where changes made if available
Linter has been run for changed code
Tests for the changes have been added if not covered yet
Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]


          Fix(cubejs-cli): Ability to select JDBC driver

e6c4c46

ovr requested a review from paveltiunov

ovr assigned paveltiunov

ovr added the bug label

ovr reviewed

packages/cubejs-cli/cubejsCli.js

  
              type: 'list',

              name: 'jdbcDriver',

              message: 'Select JDBC driver',

              choices: JDBCPackage.getSupportedDrivers()

ovr Sep 28, 2020
Author Member

Package @cubejs-backend/jdbc-driver requires version bump for local testing!


          Fix(@cubejs-backend/jdbc-driver): Expose CUBEJS_JDBC_DRIVER env to .e…

25b45a6

…nv file generation

ovr force-pushed the cubejs-cli-fix-jdbc-create branch from 085ba36 to 25b45a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.