Skip to content

/ next.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Prettier 2 #13061

Merged
merged 10 commits into from May 18, 2020
Merged

Upgrade to Prettier 2 #13061

merged 10 commits into from May 18, 2020
+1,525 −1,657

Conversation

@Timer
Copy link
Member

@Timer Timer commented May 18, 2020

This upgrades us to Prettier 2.0.

We appreciate the OP PR, but it's too much code to verify when committed by a non-maintainer. 🙏

Closes #12676
Timer added 10 commits May 18, 2020
@Timer
Upgrade Prettier Deps
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
bca4893
@Timer
Update docs
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
b787fc3
@Timer
Update errors
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
33de3d6
@Timer
Update tests
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
8fcc842
@Timer
Update examples
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
6f23354
@Timer
Update react-refresh-utils
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
6e3e09a
@Timer
Update CNA
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
dd8a1e8
@Timer
Update next
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
a362d36
@Timer
Update overlay
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
625eb64
@Timer
Update misc
Verified
This commit was signed with a verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
Loading status checks…
2847918
@Timer Timer added this to the 9.4.2 milestone May 18, 2020
@Timer Timer requested review from ijjk, lfades and timneutkens as code owners May 18, 2020
@Timer Timer changed the title Upgrade prettier Upgrade to Prettier 2 May 18, 2020
@ijjk
Copy link
Member

@ijjk ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js upgrade-prettier Change
buildDuration 11.9s 12.3s ⚠️ +451ms
nodeModulesSize 60.4 MB 60.4 MB ⚠️ +101 B
Page Load Tests Overall increase ✓
zeit/next.js canary Timer/next.js upgrade-prettier Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.952 1.95 0
/ avg req/sec 1280.78 1282.2 ⚠️ +1.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.165 1.132 -0.03
/error-in-render avg req/sec 2145.65 2208.05 ⚠️ +62.4
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js upgrade-prettier Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js upgrade-prettier Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js upgrade-prettier Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js upgrade-prettier Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js upgrade-prettier Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js upgrade-prettier Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js upgrade-prettier Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js upgrade-prettier Change
buildDuration 13.1s 12.5s -599ms
nodeModulesSize 60.4 MB 60.4 MB ⚠️ +101 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js upgrade-prettier Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js upgrade-prettier Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js upgrade-prettier Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js upgrade-prettier Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js upgrade-prettier Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js upgrade-prettier Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js upgrade-prettier Change
_error.js 851 kB 851 kB ⚠️ +16 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ⚠️ +16 B
link.js 888 kB 888 kB ⚠️ +16 B
routerDirect.js 880 kB 880 kB ⚠️ +16 B
withRouter.js 880 kB 881 kB ⚠️ +16 B
Overall change 4.36 MB 4.36 MB ⚠️ +80 B
@ijjk
ijjk approved these changes May 18, 2020
View changes
@Timer Timer merged commit 86160a5 into vercel:canary May 18, 2020
15 of 21 checks passed
15 of 21 checks passed
build
Details
PR Stats
Details
lint
Details
Check Pre-compiled
Details
Test All (1)
Details
Test All (2)
Details
Test All (3)
Details
Test All (4)
Details
Test All (5)
Details
Test All (6)
Details
Test Firefox (production)
Details
Test Safari (production)
Details
thank you, next
Details
Test Safari 10.1 (nav)
Details
Potentially publish release
Details
azure next.js (test_chrome node-10-1) test_chrome node-10-1 failed
Details
azure next.js (test_chrome node-10-2) test_chrome node-10-2 failed
Details
azure next.js (test_chrome node-10-3) test_chrome node-10-3 failed
Details
azure next.js (test_chrome node-10-4) test_chrome node-10-4 failed
Details
azure next.js (test_ie11) test_ie11 failed
Details
azure next.js
Details
@Timer Timer deleted the Timer:upgrade-prettier branch May 18, 2020
@philgruneich
Copy link

@philgruneich philgruneich commented May 19, 2020

Any reason for the with-chakra-ui example to be within the src directory?
chibicode added a commit to chibicode/next.js that referenced this pull request May 21, 2020
@Timer @chibicode
Upgrade to Prettier 2 (vercel#13061)
Verified
This commit was signed with a verified signature.
chibicode Shu Uesugi
GPG key ID: F47946D9C75DF76E Learn about signing commits
ab084fb
rokinsky added a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@Timer @rokinsky
Upgrade to Prettier 2 (vercel#13061)
6e6a39a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijjk ijjk

@lfades lfades

@timneutkens timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.4.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Timer @ijjk @philgruneich
You can’t perform that action at this time.