Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1335: org dismissal restrictions #1688

Open
wants to merge 6 commits into
base: master
from

Conversation

@AetherDeity
Copy link
Contributor

@AetherDeity AetherDeity commented Sep 9, 2020

2nd attempt at #1335

Replaces #1339

AetherDeity added 4 commits Jan 7, 2020
…_dismissal_restrictions
@AetherDeity AetherDeity force-pushed the AetherDeity:fix_org_dismissal_restrictions branch 3 times, most recently from 7a0c151 to b77d6c4 Sep 9, 2020
@AetherDeity AetherDeity force-pushed the AetherDeity:fix_org_dismissal_restrictions branch from b77d6c4 to 9bc74f2 Sep 9, 2020
@AetherDeity
Copy link
Contributor Author

@AetherDeity AetherDeity commented Sep 10, 2020

@s-t-e-v-e-n-k I think this PR addresses your comments in #1339

@AetherDeity AetherDeity force-pushed the AetherDeity:fix_org_dismissal_restrictions branch from 04cc0b9 to 2432869 Sep 11, 2020
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #1688 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1688   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          48       48           
  Lines        2561     2561           
=======================================
  Hits         2527     2527           
  Misses         34       34           
Impacted Files Coverage Δ
github/MainClass.py 95.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec4f15...2432869. Read the comment docs.

@AetherDeity AetherDeity changed the title Fix org dismissal restrictions Fix issue 1335: org dismissal restrictions Sep 23, 2020
@AetherDeity
Copy link
Contributor Author

@AetherDeity AetherDeity commented Sep 23, 2020

Anything needed from me to help move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.