Skip to content

refactor: remove code specific to IE 9 and IE 10 support #39090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

refactor: remove code specific to IE 9 and IE 10 support #39090

wants to merge 8 commits into from

Conversation

AndrewKushnir
Copy link
Contributor

This PR contains several commits that remove code specific to IE 9 and IE 10 support.
The code is no longer needed since IE 9 and IE 10 support is removed.

@AndrewKushnir AndrewKushnir added state: WIP refactoring Issue that involves refactoring or code-cleanup area: core Issues related to the framework runtime target: major This PR is targeted for the next major release area: elements Issues related to Angular Elements labels Oct 2, 2020
@ngbot ngbot bot modified the milestone: needsTriage Oct 2, 2020
@AndrewKushnir AndrewKushnir force-pushed the ie-9-10-cleanup-2 branch 3 times, most recently from 62c1cdb to 49be017 Compare October 2, 2020 19:17
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Oct 5, 2020
@AndrewKushnir AndrewKushnir marked this pull request as ready for review October 5, 2020 18:26
IgorMinar
IgorMinar approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect there to be more stuff to remove from forms, but it might be hard to identify the code paths if they were not well documented.

Otherwise this looks great! Thank you!

Reviewed-for: global-approvers

gkalpak
gkalpak approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! :shipit:

Reviewed-for: docs-infra, fw-elements, fw-upgrade

jelbourn
jelbourn approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@AndrewKushnir
test(core): remove code specific to IE 9 and IE 10
c8b49ee 
This commit updates core tests and removes the code needed to support IE 9 and IE 10 only.
The code is no longer needed since IE 9 and IE 10 support is removed in v11.
@AndrewKushnir
test(platform-browser): remove IE9 and IE10 checks from tests
3ed15c8 
This commit removes IE 9 and IE 10 checks from the browser detection spec.
Also unblocks tests that were previously disabled due to issues in IE10.
@AndrewKushnir
refactor(core): remove NG_PROV_DEF_FALLBACK needed for IE10 only
29eaef8 
This commit removes a workaround previously used for IE 9 and 10 to identify whether InjectableDef
was defined on a given class instance. Since support for IE 9 and 10 is removed, this fallback is
no longer needed.
@AndrewKushnir
refactor(elements): remove code to support IE9/10
698f8df 
Since support for IE 9 and IE 10 browsers is removed in v11, the code that was added to support
these browsers is no longer needed.
@AndrewKushnir
refactor(core): remove IE-sepcific logic from setClassMetadata function
570415b 
This commit simplifies the logic in the `setClassMetadata` function to avoid the code needed to
support IE 9 and IE 10.
@AndrewKushnir
test(core): remove IE10 reference from browserslist files
30b01ea 
This commit updates `browserslist` files to exclude IE10 references.
@AndrewKushnir
docs: remove IE10 references from comments in the code
4bf0aee
@AndrewKushnir
Copy link
Contributor Author

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 13, 2020
@AndrewKushnir
Copy link
Contributor Author

Merge assistance: it looks like there is a GitHub UI glitch where some reviewers were added twice and I'm unable to remove them from the list (thus the ci/angular: merge status is failing).

@atscott atscott closed this in 78a33ee Oct 13, 2020
atscott pushed a commit that referenced this pull request Oct 13, 2020
@AndrewKushnir @atscott
test(platform-browser): remove IE9 and IE10 checks from tests (#39090)
61e6ca9 
This commit removes IE 9 and IE 10 checks from the browser detection spec.
Also unblocks tests that were previously disabled due to issues in IE10.

PR Close #39090
atscott pushed a commit that referenced this pull request Oct 13, 2020
@AndrewKushnir @atscott
refactor(core): remove NG_PROV_DEF_FALLBACK needed for IE10 only (#39090
db37c17 
)

This commit removes a workaround previously used for IE 9 and 10 to identify whether InjectableDef
was defined on a given class instance. Since support for IE 9 and 10 is removed, this fallback is
no longer needed.

PR Close #39090
atscott pushed a commit that referenced this pull request Oct 13, 2020
@AndrewKushnir @atscott
refactor(elements): remove code to support IE9/10 (#39090)
cbef410 
Since support for IE 9 and IE 10 browsers is removed in v11, the code that was added to support
these browsers is no longer needed.

PR Close #39090
atscott pushed a commit that referenced this pull request Oct 13, 2020
@AndrewKushnir @atscott
refactor(core): remove IE-sepcific logic from setClassMetadata functi…
0001dbd 
…on (#39090)

This commit simplifies the logic in the `setClassMetadata` function to avoid the code needed to
support IE 9 and IE 10.

PR Close #39090
atscott pushed a commit that referenced this pull request Oct 13, 2020
@AndrewKushnir @atscott
test(core): remove IE10 reference from browserslist files (#39090)
a051d97 
This commit updates `browserslist` files to exclude IE10 references.

PR Close #39090
atscott pushed a commit that referenced this pull request Oct 13, 2020
@AndrewKushnir @atscott
docs: remove IE10 references from comments in the code (#39090)
8fd25d9 
PR Close #39090
gkalpak added a commit to gkalpak/angular that referenced this pull request Oct 14, 2020
@gkalpak
refactor(elements): simplify code after IE<11 support removal
e422fa0 
Support for IE<11 is being removed in v11. PR angular#39090 removed some code
that was no longer needed.

Now that there are no longer multiple code-paths (which was previously
needed for IE<11 support), this commit simplifies the code further (for
example, to avoid unnecessary functions calls and to avoid iterating
over a component's inputs multiple times).
@gkalpak gkalpak mentioned this pull request Oct 14, 2020
Closed
atscott pushed a commit that referenced this pull request Oct 14, 2020
@gkalpak @atscott
refactor(elements): simplify code after IE<11 support removal (#39265)
eb9eebb 
Support for IE<11 is being removed in v11. PR #39090 removed some code
that was no longer needed.

Now that there are no longer multiple code-paths (which was previously
needed for IE<11 support), this commit simplifies the code further (for
example, to avoid unnecessary functions calls and to avoid iterating
over a component's inputs multiple times).

PR Close #39265
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@jelbourn jelbourn jelbourn approved these changes

@gkalpak gkalpak gkalpak approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@atscott atscott Awaiting requested review from atscott

@mhevery mhevery Awaiting requested review from mhevery

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: elements Issues related to Angular Elements cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
5 participants
@AndrewKushnir @IgorMinar @jelbourn @gkalpak @googlebot