feat(compiler): support recovery of malformed property reads #39103
Conversation
alxhub
reviewed
Oct 15, 2020
const id = this.withContext(ParseContextFlags.Writable, () => { | ||
const id = this.expectIdentifierOrKeyword(); | ||
if (id.length === 0) { | ||
this.error(`Property access cannot be empty`, receiver.span.end); |
Suggested change
this.error(`Property access cannot be empty`, receiver.span.end); | |
this.error(`Expected identifier for property access`, receiver.span.end); |
alxhub
approved these changes
Oct 15, 2020
This feature is trivial to support since 89c5255 has landed.
Caretaker: could you run g3sync? |
@ayazhafiz sure, I've started a new presubmit. Note: since this is a feature, I've also changed the target to "minor", so the change will be merged into master only and will be available in v11.1.0. Please let me know if this sounds correct and feel free to update the target as needed. |
That sounds good, thank you for the update. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This feature is trivial to support since
89c5255 has landed.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
The text was updated successfully, but these errors were encountered: