Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): support recovery of malformed property reads #39103

Closed
wants to merge 2 commits into from

Conversation

@ayazhafiz
Copy link
Contributor

@ayazhafiz ayazhafiz commented Oct 3, 2020

This feature is trivial to support since
89c5255 has landed.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Feature
@ngbot ngbot bot added this to the needsTriage milestone Oct 3, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 3, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 3, 2020
@pullapprove pullapprove bot requested a review from alxhub Oct 3, 2020
@ayazhafiz ayazhafiz force-pushed the i/38596-property-write branch from 5bb9452 to 0b30cf8 Oct 4, 2020
@ayazhafiz ayazhafiz added this to PRs In Review in Ivy Language Service Oct 6, 2020
const id = this.withContext(ParseContextFlags.Writable, () => {
const id = this.expectIdentifierOrKeyword();
if (id.length === 0) {
this.error(`Property access cannot be empty`, receiver.span.end);
Copy link
Contributor

@alxhub alxhub Oct 15, 2020

Suggested change
this.error(`Property access cannot be empty`, receiver.span.end);
this.error(`Expected identifier for property access`, receiver.span.end);

alxhub
alxhub approved these changes Oct 15, 2020
@ayazhafiz ayazhafiz force-pushed the i/38596-property-write branch from 56a2e67 to fc444ca Oct 19, 2020
@ayazhafiz
Copy link
Contributor Author

@ayazhafiz ayazhafiz commented Oct 20, 2020

Caretaker: could you run g3sync?

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Oct 20, 2020

@ayazhafiz sure, I've started a new presubmit.

Note: since this is a feature, I've also changed the target to "minor", so the change will be merged into master only and will be available in v11.1.0. Please let me know if this sounds correct and feel free to update the target as needed.

@ayazhafiz
Copy link
Contributor Author

@ayazhafiz ayazhafiz commented Oct 20, 2020

That sounds good, thank you for the update.

@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Nov 22, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants