Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding files exercise #521

Open
wants to merge 3 commits into
base: main
from

Conversation

@calvinbrown085
Copy link
Contributor

@calvinbrown085 calvinbrown085 commented Sep 21, 2020

#482

This adds an example for reading in a file from the filesystem! Please let me know if I can do anything else here!

alexxroche and others added 3 commits Jul 8, 2020
Suggestion from AbdouSeck #424 (comment)
for when the student's code has errors.
@calvinbrown085 calvinbrown085 changed the title Adding files exercise feat: Adding files exercise Sep 22, 2020
@AbdouSeck
Copy link
Collaborator

@AbdouSeck AbdouSeck commented Dec 6, 2020

Hi @calvinbrown085, thanks for proposing this feature. I am trying to figure out what the learner is supposed to do here. Are you trying to have the learner write the unit test case? If so, then the exercise won't work as written. The learner does not write and update unit tests. They update functions on top of the file, and your unit tests try to check the correctness of said functions.

For instance, in the file file1.rs, what probably want to have is an incomplete function definition at the top. So, this means leaving fn create_file() -> std::io::Result<()> {} incomplete. And then, you want to write unit tests that assert! that the file has been created.

Please feel free to reach out if you wish to discuss this further.

Thanks,
Abdou

Copy link
Collaborator

@AbdouSeck AbdouSeck left a comment

Please my comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.