Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest 2020 - coding style for project_euler problem 39 #3023

Open
wants to merge 3 commits into
base: master
from
Open

Hacktoberfest 2020 - coding style for project_euler problem 39 #3023

wants to merge 3 commits into from
+22 −4

Conversation

@fa1l
Copy link

@fa1l fa1l commented Oct 8, 2020 •
edited

Describe your change:

Related to #2786

  • Added solution function.

  • Improve type hinting.

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@fa1l
improvements for project euler task 39
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8ddd7c2
@fa1l fa1l force-pushed the fa1l:master branch from f8fd826 to 8ddd7c2 Oct 8, 2020
@fa1l fa1l changed the title Hacktoberfest 2020 - coding style with default argument for project_euler problem 39 Hacktoberfest 2020 - coding style for project_euler problem 39 Oct 8, 2020
fa1l added 2 commits Oct 8, 2020
@fa1l
add tests for solution()
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
48207f8
@fa1l
fixed a typo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4194972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@fa1l
You can’t perform that action at this time.