Skip to content

/ C-Plus-Plus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Floyd Algorithm for searching for duplicates #1179

Open
wants to merge 4 commits into
base: master
from
Open

Added Floyd Algorithm for searching for duplicates #1179

wants to merge 4 commits into from

Conversation

@CyberIkshit
Copy link

@CyberIkshit CyberIkshit commented Oct 4, 2020 •
edited by gitpod-io bot

Added a cpp file for Floyd Algorithm for cycle detection Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

CyberIkshit added 3 commits Oct 4, 2020
@CyberIkshit
Add files via upload
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
d7d7080
@CyberIkshit
Update FloydAlgorithmForCycleDetection.cpp
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3154016
@CyberIkshit
Update FloydAlgorithmForCycleDetection.cpp
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0fe2d90
@CyberIkshit
Copy link
Author

@CyberIkshit CyberIkshit commented Oct 4, 2020

Could someone please help me why these automated tests are failing even though my code is perfect?
@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 4, 2020

image
@CyberIkshit
Copy link
Author

@CyberIkshit CyberIkshit commented Oct 4, 2020

Yeah, I've gone through that but unable to rectify the error from it as it is showing numerous errors in code despite my code is compiling just perfect. Actually, this is my first PR that's why having some difficulty doing it. Hope you'll help.
@Pardeep009
Pardeep009 reviewed Oct 9, 2020
View changes
search/FloydAlgorithmForCycleDetection.cpp Outdated
Output: 3
*/
#include<bits/stdc++.h>
using namespace std;

This comment has been minimized.

Sign in to view
@Pardeep009

Pardeep009 Oct 9, 2020 •
edited
Contributor

as per repo standards, you cannot use namespaces globally.
using cout, cin etc directly is not allowed, instead use std::cout, std::cin
@Pardeep009
Pardeep009 reviewed Oct 9, 2020
View changes
search/FloydAlgorithmForCycleDetection.cpp
#include<bits/stdc++.h>
using namespace std;
int findDuplicate(vector<int>& nums) {
int slow=nums[0];

This comment has been minimized.

Sign in to view
@Pardeep009

Pardeep009 Oct 9, 2020
Contributor

you have declared c style arrays, use std::array, for example see https://github.com/TheAlgorithms/C-Plus-Plus/pull/1085

This comment has been minimized.

Sign in to view
@Pardeep009

Pardeep009 Oct 9, 2020
Contributor

bits/stdc++ library is not allowed, as it is Linux specific and it also slows down compilation process. so include only required libraries.
@CyberIkshit
Update FloydAlgorithmForCycleDetection.cpp
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0d065ba
@CyberIkshit
Copy link
Author

@CyberIkshit CyberIkshit commented Oct 9, 2020

Thanks @Pardeep009 for giving such a detailed step by step solution to my problem, it was a great help.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pardeep009 Pardeep009

Assignees
No one assigned
Labels
Proper Documentation Required automated tests are failing enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@CyberIkshit @kvedala @Pardeep009
You can’t perform that action at this time.