Skip to content

/ C

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple SRT file merger. #643

Open
wants to merge 1 commit into
base: master
from
Open

Simple SRT file merger. #643

wants to merge 1 commit into from

Conversation

@saadshun
Copy link

@saadshun saadshun commented Oct 4, 2020 •
edited by gitpod-io bot

Merges two subtitle files from two different languages, for a whole season of a TV show, or 1 video if value in file is edited to 1.

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@saadshun
Simple SRT file merger. Merges two subtitle files from two different …
Loading status checks…
1710723 
…languages, for a whole season of a TV show.
@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 4, 2020

review the contribution guidelines. No reviews will be done until the code is updated per the repo standards
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Proper Documentation Required enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@saadshun @kvedala
You can’t perform that action at this time.