Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create e2e tests #141

Merged
merged 13 commits into from Jan 6, 2019
Merged

test: create e2e tests #141

merged 13 commits into from Jan 6, 2019

Conversation

@eddyerburgh
Copy link
Member

@eddyerburgh eddyerburgh commented Jan 5, 2019

  • Refactor tests to run as e2e tests

The previous tests were slow, and it was difficult to write tests that relied on a different file structure.

This PR moves all tests into an e2e directory. The directory contains self-contained projects that use vue-jest to compile SFCs. e2e/test-runner.js does a fresh npm install in each directory in e2e/__projects__ and runs jest.

Note: There is still confusing behavior, where the peer dependencies of vue-jest are being resolved relative to vue-jest, rather than the projects/dir. This behavior can be fixed once Jest adds a preserve-symlinks option—facebook/jest#5356

@eddyerburgh eddyerburgh merged commit ff3a777 into vuejs:master Jan 6, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@eddyerburgh eddyerburgh deleted the eddyerburgh:refactor-test-suite branch Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.