Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: external css properly handle html5-compliant syntax #287
Conversation
|
Great, will need rebase (conflicts). |
|
Yea, sure, didn't want to ship these two things (this one & #286) in a single PR, so the conflicts were inevitable here. |
|
No rush, I tend to releases on fri/sat anyway, so I can test it out a bit! |
added 2 commits
Sep 24, 2020
FRSgit
force-pushed the
FRSource:fix-external-css-properly-handle-HTML5-syntax
branch
from
2586a1e
to
909e172
|
@lmiller1990 done! |
|
I will release early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vue-jestfails when using proper html5 syntax when including external css files.When I import external CSS in a following way (that's something recommended by vue-loader and only way handled properly by vetur - they do not support highlighting of self-closing
styletags):vue-jestfails - it treats this style block as there would be nosrcattribute at all!Fixed that case (added
content.trim()- that's becausevue/component-compilerfor<style></style>returns bunch of spaces - something like: " ").