Skip to content

/ docs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct for windows slashes in redirect `precompile` #312

Open
wants to merge 3 commits into
base: main
from
Open

correct for windows slashes in redirect `precompile` #312

wants to merge 3 commits into from
+2 −1

Conversation

@jeffmcaffer
Copy link
Contributor

@jeffmcaffer jeffmcaffer commented Oct 9, 2020

Why:

resolves: #311

What's being changed:

see issue

Check off the following:
@jeffmcaffer
correct for windows slashes in redirect `precompile`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b1f1e1c
@jeffmcaffer jeffmcaffer requested a review from chiedo Oct 9, 2020
@jeffmcaffer jeffmcaffer requested a review from github/docs-engineering as a code owner Oct 9, 2020
@deploy-to-heroku deploy-to-heroku bot temporarily deployed to docs-312--jeffmcaffer-patch-2 Oct 9, 2020 Inactive
@janiceilene janiceilene added this to Engineering in Docs team reviews Oct 9, 2020
@jeffmcaffer
add missing slash require
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d16c1f2
@deploy-to-heroku deploy-to-heroku bot temporarily deployed to docs-312--jeffmcaffer-patch-2 Oct 9, 2020 Inactive
@heiskr
heiskr approved these changes Oct 9, 2020
View changes
Copy link
Contributor

@heiskr heiskr left a comment

🙏🏼 Thanks!
@zeke
Merge branch 'main' into jeffmcaffer-patch-2
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f45e503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiskr heiskr

@chiedo chiedo

Assignees
No one assigned
Labels
engineering windows
Projects
Docs team reviews
Engineering
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

developer route redirects load incorrectly on Windows
4 participants
@jeffmcaffer @heiskr @janiceilene @zeke
You can’t perform that action at this time.