Skip to content

/ ArduinoCore-sam

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update uotghs_host.c #66

Open
wants to merge 2 commits into
base: master
from
Open

Update uotghs_host.c #66

wants to merge 2 commits into from

Conversation

@martinzw
Copy link

@martinzw martinzw commented Apr 22, 2019

If you try to read longer messages (>256 bytes) from USB device from host side, the buffer rolls over overwriting the buffer.
For DUE/SAM can handle pipes with 1024 bytes, a uint16_t should be used here.

I needed this for example to be able to read 512 bytes of data from a USB-Midi device.
@martinzw
Update uotghs_host.c
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
63b4e02 
If you try to read longer messages (>256 bytes)  from USB device from host side, the buffer rolls over overwriting the buffer.
For DUE/SAM can handle pipes with 1024 bytes, a uint16_t  should be used.
@per1234
per1234 suggested changes Apr 23, 2019
View changes
system/libsam/source/uotghs_host.c Outdated
@@ -360,7 +360,7 @@ void UHD_Pipe_Free(uint32_t ul_pipe)
uint32_t UHD_Pipe_Read(uint32_t ul_pipe, uint32_t ul_size, uint8_t* data)
{
uint8_t *ptr_ep_data = 0;
uint8_t nb_byte_received = 0;
uint16_t nb_byte_received = 0; //otherwise roll over when reading pipe >256 Bytes

This comment has been minimized.

Sign in to view
@per1234

per1234 Apr 23, 2019
Contributor

I feel the comment on this line will be confusing when read without the context of the other information in this pull request. If the comment is to be there, I think it could be better worded.

This comment has been minimized.

Sign in to view
@martinzw

martinzw Apr 23, 2019
Author

You are right.
Changed comment
@martinzw
Update uotghs_host.c
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7a44418
@martinzw martinzw mentioned this pull request May 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@martinzw @per1234
You can’t perform that action at this time.