Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui update support buttons #248

Merged
merged 2 commits into from Oct 8, 2020
Merged

ui update support buttons #248

merged 2 commits into from Oct 8, 2020

Conversation

@Arhell
Copy link
Contributor

@Arhell Arhell commented Oct 8, 2020

Why:

Fixes #237 . button position

What's being changed:

before in issue #237
After fix
2
3

Check off the following:

Review page

cc @github/docs-engineering

@welcome
Copy link

@welcome welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added this to Triage in Docs team reviews Oct 8, 2020
Copy link

@dwarkeshkaswala dwarkeshkaswala left a comment

Reviewed

Copy link
Member

@JasonEtco JasonEtco left a comment

This looks great, thanks for the fix @Arhell!!

@JasonEtco JasonEtco merged commit 3d05341 into github:main Oct 8, 2020
12 of 13 checks passed
12 of 13 checks passed
triage
Details
automerge
Details
automerge
Details
automerge
Details
automerge
Details
lint
Details
test (content)
Details
test (meta)
Details
test (rendering)
Details
test (routing)
Details
test (unit)
Details
test (links-and-images)
Details
staging failed to deploy. see logs
Details
@chiedo chiedo moved this from Triage to Engineering in Docs team reviews Oct 8, 2020
@chiedo chiedo added the engineering label Oct 8, 2020
@Arhell Arhell deleted the Arhell:ui-button-upd branch Oct 8, 2020
@chiedo chiedo moved this from Engineering to Done in Docs team reviews Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.