Skip to content

/ docs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim pre- and post-amble in the CC-BY license text #291

Open
wants to merge 2 commits into
base: main
from
Open

Trim pre- and post-amble in the CC-BY license text #291

wants to merge 2 commits into from

Conversation

@jeffmcaffer
Copy link
Contributor

@jeffmcaffer jeffmcaffer commented Oct 8, 2020

Why:

The CC-BY license file has extra text that is not intended to be part of the license itself.
See #275

closes #275

What's being changed:

Trim the extraneous text with guidance from the legal team.
@jeffmcaffer
Trim pre- and post-amble in the CC-BY license text
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1b6e8ea
@jeffmcaffer jeffmcaffer requested review from zeke and tom-corbett Oct 8, 2020
@deploy-to-heroku deploy-to-heroku bot temporarily deployed to docs-291--jeffmcaffer-patch-1 Oct 8, 2020 Inactive
@jeffmcaffer
Copy link
Contributor Author

@jeffmcaffer jeffmcaffer commented Oct 8, 2020

Need to validate that the new text is properly detected by licensee. Hold off merging until validated.
@github-actions github-actions bot added this to Triage in Docs team reviews Oct 8, 2020
@zeke
zeke approved these changes Oct 8, 2020
View changes
Copy link
Member

@zeke zeke left a comment

Looks good. Thanks for working on this 👍🏼
@zeke
Merge branch 'main' into jeffmcaffer-patch-1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f6829e8
@jeffmcaffer jeffmcaffer mentioned this pull request Oct 8, 2020
Open
@jeffmcaffer
Copy link
Contributor Author

@jeffmcaffer jeffmcaffer commented Oct 8, 2020

Turns out that licensee does NOT detect this new text correctly. I chatted briefly with @benbalter and opened licensee/licensee#464. Two choices here:

  1. merge this now. The user experience will likely be the same in that they should still see View license and should still be guided to the LICENSE file.
  2. wait for the licensee fix.
  3. close this as won't fix. The text is not invalid, it's just "overly complete"

I have no preference one way or another.
@chiedo chiedo moved this from Triage to Done in Docs team reviews Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeke zeke

@tom-corbett tom-corbett

Assignees
No one assigned
Labels
engineering
Projects
Docs team reviews
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

new LICENSE file incorrect, and would not be detected by github
2 participants
@jeffmcaffer @zeke
You can’t perform that action at this time.