Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions code example "with" syntax to map instead of array #343

Open
wants to merge 1 commit into
base: main
from

Conversation

@Shegox
Copy link

@Shegox Shegox commented Oct 9, 2020

Why:

The GitHub Action examples on the codeql page (https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning) use the "with" as an array, but this needs to be a map (see the actions docs here).

What's being changed:

Update GitHub Action code snippet on the "configuring code scanning" page to use correct map syntax for the variables in the "with" attribute instead of the array syntax.

Check off the following:

@welcome
Copy link

@welcome welcome bot commented Oct 9, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added this to Triage in Docs team reviews Oct 9, 2020
@janiceilene
Copy link
Contributor

@janiceilene janiceilene commented Oct 9, 2020

👋 @Shegox Thanks for opening a PR! Please fill out the missing section of the PR template "What's being changed," then we can get this triaged for review

@Shegox
Copy link
Author

@Shegox Shegox commented Oct 9, 2020

Hi @janiceilene,

updated the section. Please let me know if I should further elaborate that. Thanks.

@janiceilene
Copy link
Contributor

@janiceilene janiceilene commented Oct 9, 2020

Thanks so much @Shegox! I'll get this triaged for review 💝

@janiceilene janiceilene moved this from Triage to DSP in Docs team reviews Oct 9, 2020
@janiceilene janiceilene added the DSP label Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.