Skip to content

A11Y: Topic notifications button needs aria-label #10727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

A11Y: Topic notifications button needs aria-label #10727

wants to merge 2 commits into from

Conversation

awesomerobot
Copy link
Member

@awesomerobot
Copy link
Member Author

Not sure if this is the best way to do this with select-kit, can you take a look @jjaffeux?

@SamSaffron
Copy link
Member

I think this is allowed @jjaffeux shall we merge?

@jjaffeux jjaffeux closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamSaffron SamSaffron SamSaffron approved these changes

@jjaffeux jjaffeux Awaiting requested review from jjaffeux

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awesomerobot @SamSaffron @jjaffeux