rubocop-hq / ruby-style-guide

Sponsor

Sponsor rubocop-hq/ruby-style-guide
Watch 590
Star 15.4k
Fork 3.4k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#359 - No Hanging Indentation #725

Open

baweaver wants to merge 1 commit into rubocop-hq:master from baweaver:patch-2

baweaver commented Aug 15, 2018

Based off of a very old issue that had a lot of interesting discussion:

The idea here is that hanging indentation is incredibly hard to read while going down a page, and also incurs extra editing whenever more methods are added to a chain.


        #359 - No Hanging Indentation

a0fe2f5

Based off of a very old issue that had a lot of interesting discussion:

#359

The idea here is that hanging indentation is incredibly hard to read while going down a page, and also incurs extra editing whenever more methods are added to a chain.

bbatsov reviewed

  
          ```ruby

          # bad (hanging indent)

          some_method.with.a_longer.chain(:parameter_1,

bbatsov Aug 16, 2018

Collaborator

I think this needs to be made clear with respect to:

no method chain - e.g. some_method(a,
short method chain - frankly it seems to the example you deleted looks fine, as it's not really a long method chain.

bbatsov reviewed

  
      @@ -643,6 +635,40 @@ Translations of the guide are available in the following languages:
    
          end

          ```

        * <a name="no-hanging-indent"></a>

bbatsov Aug 16, 2018

Collaborator

Maybe no-hanging-param-indent or something like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.