Skip to content

/ vuex

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: migrate tests to jest #1738

Merged
merged 4 commits into from May 8, 2020
Merged

build: migrate tests to jest #1738

merged 4 commits into from May 8, 2020
+2,346 −743

Conversation

@kiaking
Copy link
Member

@kiaking kiaking commented Apr 30, 2020 •
edited

Migrate test framework to Jest.

  • All unit tests are written in Jest.
  • Moved setup files out of unit filter and place it under test. This is for migrating E2E test to use Puppeteer instead of Nightwatch. In that time, we should be able to reuse this file since the test will all run with Jest.
  • Updated Babel to the latest.
  • Remove babel-polyfill due to deprecation. In the examples, we could add core-js pattern described here at the top.
  • Added yarn coverage to generate test coverage.
@kiaking kiaking added the build label Apr 30, 2020
@kiaking kiaking requested a review from ktsn Apr 30, 2020
@kiaking kiaking self-assigned this Apr 30, 2020
@kiaking kiaking force-pushed the jest branch 2 times, most recently from 4131642 to 384b50f Apr 30, 2020
@Kocal
Copy link

@Kocal Kocal commented Apr 30, 2020 •
edited

This is for migrating E2E test to use prettier instead of Nightwatch

Do you mean Cypress instead of Prettier?
@kiaking
Copy link
Member Author

@kiaking kiaking commented Apr 30, 2020 •
edited

Do you mean Cypress instead of Prettier?

Sorry, I meant Puppeteer 🤦‍♂️ (fixed). I love Cypress! Though we're trying align with Vue 3.
@ktsn
ktsn reviewed May 4, 2020
View changes
.babelrc Outdated Show resolved Hide resolved
test/.eslintrc Outdated Show resolved Hide resolved
kiaking added 4 commits Apr 30, 2020
@kiaking
build: migrate tests to jest
4512508
@kiaking
build: remove babel object-rest-spread plugin
33913da
@kiaking
chore: rename `.eslintrc` to `.eslintrc.json`
0909b56
@kiaking
chore: update `.eslintrc` in the test folder too
Loading status checks…
7c7d264
@kiaking kiaking force-pushed the jest branch from 64d67a0 to 7c7d264 May 8, 2020
@kiaking
Copy link
Member Author

@kiaking kiaking commented May 8, 2020

@ktsn Updated and also rebased to the latest branch 👍
@ktsn
ktsn approved these changes May 8, 2020
View changes
Copy link
Member

@ktsn ktsn left a comment

👍
@ktsn ktsn merged commit dfacba6 into dev May 8, 2020
6 checks passed
6 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@ktsn ktsn deleted the jest branch May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn

Assignees

@kiaking kiaking

Labels
build
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kiaking @Kocal @ktsn
You can’t perform that action at this time.