Skip to content

/ vue-jest

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change single-quote to double-quote in npm-scripts #277

Merged
merged 2 commits into from Sep 17, 2020
Merged

fix: change single-quote to double-quote in npm-scripts #277

merged 2 commits into from Sep 17, 2020

Conversation

@nogic1008
Copy link
Contributor

@nogic1008 nogic1008 commented Sep 11, 2020

Windows PowerShell does not support single-quoted arguments.
This repo hooks npm script on commit, so we cannot develop in windows environment.

This PR changes args to double-quoted, and changes npm run command to yarn.
nogic1008 added 2 commits Sep 11, 2020
@nogic1008
fix: change single-quote to double in npm-scripts
166a857
@nogic1008
chore: use yarn on npm-scripts
Loading status checks…
6e02256
@lmiller1990 lmiller1990 merged commit 19fe8c4 into vuejs:master Sep 17, 2020
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@nogic1008 nogic1008 deleted the nogic1008:hotfix/npm-scripts branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@nogic1008 @lmiller1990
You can’t perform that action at this time.