Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure working with Vue 3 + custom babel config #258

Open
lmiller1990 opened this issue Jul 29, 2020 · 9 comments
Open

Ensure working with Vue 3 + custom babel config #258

lmiller1990 opened this issue Jul 29, 2020 · 9 comments
Labels
5.x

Comments

@lmiller1990
Copy link
Member

@lmiller1990 lmiller1990 commented Jul 29, 2020

Issue found here: vuejs/vue-cli#5714

@lmiller1990

Loading…

Member Author

@lmiller1990 lmiller1990 commented Aug 1, 2020

Should be good in 5.0.0-alpha.2

@Amour1688

Loading…

Member

@Amour1688 Amour1688 commented Aug 11, 2020

I got error in 5.0.0-aplha.3.

image

image

My Babel config

https://github.com/vueComponent/ant-design-vue/blob/feat-vue3/.babelrc

@lmiller1990

Loading…

Member Author

@lmiller1990 lmiller1990 commented Aug 11, 2020

I will take a look at your project. I guess it isn't respecting .babelrc? 🤔

@Amour1688

Loading…

Member

@Amour1688 Amour1688 commented Aug 12, 2020

I will take a look at your project. I guess it isn't respecting .babelrc? 🤔

yeah, it works when I renamed it to babel.config.js.

@lmiller1990

Loading…

Member Author

@lmiller1990 lmiller1990 commented Aug 13, 2020

I think the later versions of babel don't support .babelrc. Is this a good enough fix for your project? Or do we need to leave this open?

@Wizard67

Loading…

@Wizard67 Wizard67 commented Sep 8, 2020

How to suport <script setup>?

@lmiller1990

Loading…

Member Author

@lmiller1990 lmiller1990 commented Sep 8, 2020

I have not tried this yet. I was hoping it would "just work" - the SFC compiler (should) take care of it, mostly.

What happens when you tried it?

@Wizard67

Loading…

@Wizard67 Wizard67 commented Sep 8, 2020

I have not tried this yet. I was hoping it would "just work" - the SFC compiler (should) take care of it, mostly.

What happens when you tried it?

@vue/runtime-core warns [Vue warn]: Property "x" was accessed during render but is not defined on instance. when I run the test script.

reproduction link: https://github.com/Wizard67/vue3-test

@lmiller1990

Loading…

Member Author

@lmiller1990 lmiller1990 commented Sep 9, 2020

Yep, we need to do a check for <script setup>. This should be fairly easy, I will look into it tomorrow or Friday.

More info here: https://github.com/vuejs/rfcs/blob/sfc-improvements/active-rfcs/0000-sfc-script-setup.md#transform-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.