Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of warnings in travis for newer php versions #163

Open
tflori opened this issue Jul 14, 2020 · 1 comment
Open

A lot of warnings in travis for newer php versions #163

tflori opened this issue Jul 14, 2020 · 1 comment

Comments

@tflori
Copy link
Member

@tflori tflori commented Jul 14, 2020

The problem is that newer versions are not working on the old php versions - we are staying somehow at a point where it would be the easiest solution to just split up the development with a v3 branch and a new v4 that is only compatible with php 7.1 (I guess will be the matching point where all libraries work on all new versions).

Another option would be to upgrade the packages only in travis (split the jobs to use different versions (with composer require phpunit:8.* for example).

Two dependencies are at fault: PHPUnit and PHP Code Sniffer.

PHPUnit starts spitting deprecated issues with 7.2 and PHP Code Sniffer with 7.4. I guess it is worth giving it a try with the latest versions of both dependencies in 7.4 and see how it reacts, not sure if the source will have to be edited to do so though. What do you think of doing this in a follow up PR to unblock this one?

Originally posted by @PierrickVoulet in #162 (comment)

@PierrickVoulet
Copy link
Contributor

@PierrickVoulet PierrickVoulet commented Jul 14, 2020

I think option # 1 makes sense because <=7.1 versions already reached End of Life as per PHP documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.