Skip to content

/ C-Plus-Plus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create house_robber.cpp #1247

Open
wants to merge 5 commits into
base: master
from
Open

Create house_robber.cpp #1247

wants to merge 5 commits into from
+95 −0

Conversation

@SumukhBhardwaj
Copy link

@SumukhBhardwaj SumukhBhardwaj commented Oct 10, 2020 •
edited by gitpod-io bot

Added House Robber problem, solved using dynamic programming

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@SumukhBhardwaj
Create house_robber.cpp
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
976a348
@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 11, 2020

Does your code conform to the standards and the checklist?
image
@SumukhBhardwaj
Copy link
Author

@SumukhBhardwaj SumukhBhardwaj commented Oct 11, 2020

Does your code conform to the standards and the checklist?
image

Yes I have added enough comments and also take care of naming conventions.
@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 11, 2020

It does not follow the repo standards. All the details are provided in the links in the checklist. Please review and update the code accordingly. No reviews will be provided until the code is updated to the repo standards.
Thank you for your contribution.
@SumukhBhardwaj
Update house_robber.cpp
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8ee04cd 
added test cases and solution description
@SumukhBhardwaj
Copy link
Author

@SumukhBhardwaj SumukhBhardwaj commented Oct 11, 2020

It does not follow the repo standards. All the details are provided in the links in the checklist. Please review and update the code accordingly. No reviews will be provided until the code is updated to the repo standards.
Thank you for your contribution.

Please review now, i have added test cases and solution as well.
@SumukhBhardwaj
Update house_robber.cpp
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b54ad1 
Refactored code
@SumukhBhardwaj
Update house_robber.cpp
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8a2f1e2 
Refactored code
@SumukhBhardwaj
Copy link
Author

@SumukhBhardwaj SumukhBhardwaj commented Oct 11, 2020

@kvedala please review it now. I have done all the required changes.
@SumukhBhardwaj
Update house_robber.cpp
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0536f25 
Refactored code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Proper Documentation Required awaiting modification enhancement good first issue requested changes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SumukhBhardwaj @kvedala @Panquesito7
You can’t perform that action at this time.