Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow data: to not be part of sanitizer’s allowed protocols #412
Conversation
When `data:` wasn’t permitted, it could attempt to `del attrs[attr]` twice.
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 50 50
Lines 6952 6952
Branches 1328 1328
=======================================
Hits 6312 6312
Misses 481 481
Partials 159 159
Continue to review full report at Codecov.
|
|
The change looks valid, but shouldn't there be a test case for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When
data:wasn’t permitted, it could attempt todel attrs[attr]twice.