Skip to content

/ html5lib-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move serialiser tests over to generating test objects from the JSON files #367

Open
willkg opened this issue Nov 27, 2017 · 3 comments
Open

move serialiser tests over to generating test objects from the JSON files #367

willkg opened this issue Nov 27, 2017 · 3 comments

Comments

@willkg
Copy link
Contributor

@willkg willkg commented Nov 27, 2017

From #182.

The serializer tests seem to be in html5lib/tests/test_serializer.py.
@willkg
Copy link
Contributor Author

@willkg willkg commented Nov 27, 2017

@gsnedders The tokenizer tests look like they're in html5lib/tests/testdata/tokenizer/ already. Are there other tests you wanted to move over?
@gsnedders
Copy link
Member

@gsnedders gsnedders commented Nov 28, 2017

Yeah, tokenisers have been done. Basically everything using the testdata files should be using the same structure with subclasses of pytest.Item.
@willkg willkg changed the title move tokenizer and serialiser tests over to generating test objects from the JSON files move serialiser tests over to generating test objects from the JSON files Nov 29, 2017
@willkg
Copy link
Contributor Author

@willkg willkg commented Nov 29, 2017

Adjusted the title accordingly. Thanks, @gsnedders !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@gsnedders @willkg
You can’t perform that action at this time.