Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDrop six 1.9 support #370
Drop six 1.9 support #370
Comments
|
I wonder if this isn't related to Travis, but rather that we don't specify which version of pytest to install and use: https://github.com/html5lib/html5lib-python/blob/master/requirements-test.txt#L4 I forget if that file affects what gets installed, but can look into it in a couple of hours or tomorrow. |
|
Whatever the cause, this is no longer happening, the 3.6 env is passing on Travis (and all of them: 2.7, 3.5-3.8, PyPy and PyPy3). Latest master build: Edit: the issue appeared in pytest 3.3.0, and was fixed by pinning Can this issue now be closed? In case you do want to bump to six 1.10, here's a passing branch I can PR: |
The version of
pyteston Travis's 3.6 environment seems to rely onsix>=1.10so oursix==1.9test config fails. See, e.g., https://travis-ci.org/html5lib/html5lib-python/jobs/308631931Given 1.10 is now over two years old, I'd hope we can drop support for 1.9, and fix this by just bumping our min required version to 1.10.