Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX: Navbar active link's styling for all section should be same for better user experience #268

Open
dwarcash opened this issue Oct 8, 2020 · 3 comments

Comments

@dwarcash
Copy link

@dwarcash dwarcash commented Oct 8, 2020

What is the current behavior?

👉 Opening navbar, in language selector, selected language as active link styling is not same as the version selector's

👉 In mobile site, selected language in drop down is not much visible as the selected one

Screenshot 2020-10-08 190922
Screenshot 2020-10-08 192407
Screenshot 2020-10-08 190857

What changes are you suggesting?

👉 For better User Experience, active links should be same on both sections

👉 In mobile view, setting active language styling same as version section has a better user experience

Screenshot 2020-10-08 195605
Screenshot 2020-10-08 195652

Additional information
No additional information

@dwarcash dwarcash added the engineering label Oct 8, 2020
@welcome
Copy link

@welcome welcome bot commented Oct 8, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage label Oct 8, 2020
@github-actions github-actions bot added this to Triage in Docs team reviews Oct 8, 2020
@dwarcash dwarcash changed the title UI/UX: Navbar active links for all section should be same for better user experience UI/UX: Navbar active link's styling for all section should be same for better user experience Oct 8, 2020
@janiceilene janiceilene closed this Oct 8, 2020
Docs team reviews automation moved this from Triage to Done Oct 8, 2020
@janiceilene janiceilene reopened this Oct 8, 2020
@janiceilene
Copy link
Contributor

@janiceilene janiceilene commented Oct 8, 2020

Thanks for opening an issue @dwarcash! I'll triage this for @github/docs-engineering to respond 🌟

@janiceilene janiceilene removed the triage label Oct 8, 2020
@janiceilene janiceilene moved this from Done to Engineering in Docs team reviews Oct 8, 2020
@dwarcash
Copy link
Author

@dwarcash dwarcash commented Oct 9, 2020

Thanks for reopening @janiceilene !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.