Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to import Mapping and MutableMapping from collections.abc #403

Merged
merged 1 commit into from Oct 1, 2018

Conversation

@5j9
Copy link
Contributor

@5j9 5j9 commented Sep 23, 2018

Note that collections.abc has been added in Python 3.3.

Fixes #402

Note that collections.abc has been added in Python 3.3.

Fixes #402
@5j9 5j9 force-pushed the 5j9:master branch from 9d53c9c to 322a2d5 Sep 23, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Sep 23, 2018

Codecov Report

Merging #403 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   90.76%   90.77%   +<.01%     
==========================================
  Files          50       50              
  Lines        6950     6956       +6     
  Branches     1328     1328              
==========================================
+ Hits         6308     6314       +6     
  Misses        483      483              
  Partials      159      159
Impacted Files Coverage Δ
html5lib/_trie/_base.py 61.53% <100%> (+5.01%) ⬆️
html5lib/treebuilders/dom.py 89.41% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950ea0e...322a2d5. Read the comment docs.

@5j9 5j9 changed the title Try to import MutableMapping from collections.abc Try to import Mapping and MutableMapping from collections.abc Sep 23, 2018
Copy link
Member

@gsnedders gsnedders left a comment

Thanks for fixing this!

@gsnedders gsnedders merged commit 4f92357 into html5lib:master Oct 1, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 90.76%)
Details
codecov/project 90.77% (+<.01%) compared to 950ea0e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@astrojuanlu
Copy link

@astrojuanlu astrojuanlu commented Jan 29, 2019

Would be great to have a release shipping this among the other improvements!

@pllim
Copy link

@pllim pllim commented Nov 8, 2019

Still no release with this patch after a year? 😢

@zsol
Copy link

@zsol zsol commented Dec 20, 2019

Edit: apologies for the noise, there's already discussion happening about this in #419.

This is now breaking with Python 3.9:

❯ python
Python 3.9.0a2+ (heads/master:b0d4949, Dec 20 2019, 11:38:30)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import html5lib
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/__init__.py", line 25, in <module>
    from .html5parser import HTMLParser, parse, parseFragment
  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/html5parser.py", line 8, in <module>
    from . import _tokenizer
  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/_tokenizer.py", line 16, in <module>
    from ._trie import Trie
  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/_trie/__init__.py", line 3, in <module>
    from .py import Trie as PyTrie
  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/_trie/py.py", line 6, in <module>
    from ._base import Trie as ABCTrie
  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/_trie/_base.py", line 3, in <module>
    from collections import Mapping
ImportError: cannot import name 'Mapping' from 'collections' (/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/collections/__init__.py)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.