Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42000: Cleanup the AST related C-code #22641

Merged
merged 1 commit into from Oct 10, 2020

Conversation

isidentical
Copy link
Sponsor Member

@isidentical isidentical commented Oct 10, 2020

  • Use the proper asdl sequence when creating empty arguments
  • Remove reduntant casts (thanks to new typed asdl_sequences)
  • Remove MarshalPrototypeVisitor and some utilities from asdl generator
  • Fix the header of Python/ast.c (kept from pgen times)

https://bugs.python.org/issue42000

Automerge-Triggered-By: @pablogsal

- Use the proper asdl sequence when creating empty arguments
- Remove reduntant casts (thanks to new typed asdl_sequences)
- Remove MarshalPrototypeVisitor and some utilities from asdl generator
- Fix the header of `Python/ast.c` (kept from pgen times)
@pablogsal pablogsal added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Oct 10, 2020
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Nice!

@miss-islington
Copy link
Contributor

miss-islington commented Oct 10, 2020

@isidentical: Status check is done, and it's a success .

@miss-islington miss-islington merged commit 02a1603 into python:master Oct 10, 2020
3 checks passed
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
- Use the proper asdl sequence when creating empty arguments
- Remove reduntant casts (thanks to new typed asdl_sequences)
- Remove MarshalPrototypeVisitor and some utilities from asdl generator
- Fix the header of `Python/ast.c` (kept from pgen times)

Automerge-Triggered-By: @pablogsal
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
- Use the proper asdl sequence when creating empty arguments
- Remove reduntant casts (thanks to new typed asdl_sequences)
- Remove MarshalPrototypeVisitor and some utilities from asdl generator
- Fix the header of `Python/ast.c` (kept from pgen times)

Automerge-Triggered-By: @pablogsal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants