Skip to content

/ scikit-learn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Fixes lgtm errors with C/C++ #14041

Merged
merged 1 commit into from Jun 13, 2019
Merged

MAINT Fixes lgtm errors with C/C++ #14041

merged 1 commit into from Jun 13, 2019

Conversation

@thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Jun 7, 2019 •
edited

Reference Issues/PRs

Fixes #14025

What does this implement/fix? Explain your changes.

There is strange hash mismatch error that is happening when C++/C is being analyzed.
@thomasjpfan
MAINT Fixes lgtm errors
Unverified
This user has not uploaded their public key yet.
GPG key ID: 5053916AEEEBE585 Learn about signing commits
Loading status checks…
ec39c8b
@thomasjpfan
Copy link
Member Author

@thomasjpfan thomasjpfan commented Jun 7, 2019

This PR fails lgtm because master fails (strangely). From the same link, we can see that this branch succeeded to be build and be analyzed.
@jnothman
jnothman approved these changes Jun 13, 2019
View changes
@jnothman
Copy link
Member

@jnothman jnothman commented Jun 13, 2019

Let's try it.
@jnothman jnothman merged commit 73caac2 into scikit-learn:master Jun 13, 2019
15 of 16 checks passed
15 of 16 checks passed
LGTM analysis: C/C++ Analysis failed (could not build the base commit (abf7721))
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing abf7721...ec39c8b
Details
codecov/project 96.81% remains the same compared to abf7721
Details
scikit-learn.scikit-learn Build #20190607.7 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_np_atlas) Linux py35_np_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda) Linux pylatest_conda succeeded
Details
scikit-learn.scikit-learn (Windows py35_32) Windows py35_32 succeeded
Details
scikit-learn.scikit-learn (Windows py37_64) Windows py37_64 succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda) macOS pylatest_conda succeeded
Details
koenvandevelde added a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@thomasjpfan @koenvandevelde
MAINT Fixes lgtm errors (scikit-learn#14041)
5454800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Disable LGTM for javascript and C++
2 participants
@thomasjpfan @jnothman